jnturton commented on code in PR #2929:
URL: https://github.com/apache/drill/pull/2929#discussion_r1796491808
##########
contrib/storage-splunk/src/main/java/org/apache/drill/exec/store/splunk/SplunkSchema.java:
##########
@@ -148,8 +183,24 @@ private void registerIndexes() {
registerTable(SPL_TABLE_NAME, new DynamicDrillTable(plugin,
plugin.getName(),
new SplunkScanSpec(plugin.getName(), SPL_TABLE_NAME, plugin.getConfig(),
queryUserName)));
+ Set<String> indexList = null;
// Retrieve and add all other Splunk indexes
- for (String indexName : connection.getIndexes().keySet()) {
+ // First check the cache to see if we have a list of indexes.
+ String nameKey = getNameForCache();
+ if (useCache) {
+ indexList = cache.getIfPresent(nameKey);
+ }
Review Comment:
@cgivre is the cache really storing one Splunk index per key? Here it looks
to me like there's a single cache key derived from the queryUserName and the
plugin name that holds a list of indexes. Or am I just being confused by the
Caffeine API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@drill.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
