jnturton commented on code in PR #2987:
URL: https://github.com/apache/drill/pull/2987#discussion_r2077669175
##########
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestNestedDateTimeTimestamp.java:
##########
@@ -46,6 +48,13 @@ public class TestNestedDateTimeTimestamp extends
BaseTestQuery {
private static final String DATAFILE =
"cp.`datetime.parquet`";
private static final Map<String, Object> expectedRecord = new
TreeMap<String, Object>();
+ @BeforeClass
+ public static void setUpTimeZone() {
Review Comment:
I think the correct way to do it is to understand if these failing tests are
telling us that something is genuinely broken in other time zones. If it is
then the tests stay as is and the code gets fixed. Or, perhaps the test code is
being dumb about time zones in which case that code gets a fix. Last resort for
me would be "sorry it only works in UTC". Whichever it is, I think merits its
own issue and PR so that its documented and searchable while in this PR it's a
bit concealed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
