cgivre commented on code in PR #3016:
URL: https://github.com/apache/drill/pull/3016#discussion_r2314364164
##########
contrib/storage-phoenix/pom.xml:
##########
@@ -313,98 +200,28 @@
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- <exclusion>
- <groupId>javax.servlet</groupId>
- <artifactId>servlet-api</artifactId>
- </exclusion>
- <exclusion>
- <groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.zaxxer</groupId>
- <artifactId>HikariCP-java7</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.apache.commons</groupId>
- <artifactId>commons-csv</artifactId>
- </exclusion>
</exclusions>
</dependency>
+
+
</dependencies>
+
<build>
<plugins>
- <plugin>
- <artifactId>maven-resources-plugin</artifactId>
- <executions>
- <execution>
- <id>copy-java-sources</id>
- <phase>process-sources</phase>
- <goals>
- <goal>copy-resources</goal>
- </goals>
- <configuration>
-
<outputDirectory>${basedir}/target/classes/org/apache/drill/exec/store/phoenix</outputDirectory>
- <resources>
- <resource>
-
<directory>src/main/java/org/apache/drill/exec/store/phoenix</directory>
- <filtering>true</filtering>
- </resource>
- </resources>
- </configuration>
- </execution>
- </executions>
- </plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<skipTests>${skipTests}</skipTests>
- <forkCount combine.self="override">1</forkCount>
+ <forkCount>1</forkCount>
<reuseForks>false</reuseForks>
- <includes>
- <include>**/PhoenixTestSuite.class</include>
- <include>**/SecuredPhoenixTestSuite.class</include>
- </includes>
- <excludes>
- <exclude>**/*Test.java</exclude>
- </excludes>
- <argLine>-Xms2048m -Xmx2048m</argLine>
+ <argLine>
+ -Xms2048m -Xmx2048m
+ --add-opens=java.base/java.lang=ALL-UNNAMED
+ --add-opens=java.base/java.util=ALL-UNNAMED
+ </argLine>
</configuration>
</plugin>
</plugins>
</build>
- <profiles>
- <profile>
Review Comment:
OK.. Let's do this. Can we merge this, and we'll create a new PR to remove
Hadoop 2 support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
