cgivre commented on PR #3023:
URL: https://github.com/apache/drill/pull/3023#issuecomment-3318984465

   > Hi @cgivre, I was thinking about the suggestion for a setting to 
enable/disable caching per plugin and I got stuck on the idea of when to cache 
and when not to. I think the best solution right now is to disable caching all 
together when one of the used plugins is set to disabled for caching, since I 
am not sure how a partially cached query plan would work (if it could even 
work).
   > 
   > I didn't get much time to look at the code yet, but I would like to hear 
your thoughts about the settings per plugin.
   
   The whole idea of partially cached query plans is extremely tricky.  I think 
but could be wrong but there may have been some work on that from the Calcite 
team at one point.  
   
   In any event, my suggestion would be to start simple.  Let's get all the 
unit tests to pass and just start with simple caching.  IE: exact query match.  
Once that's done and merged, we can iterate and find improvements.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to