pjfanning commented on code in PR #3056: URL: https://github.com/apache/drill/pull/3056#discussion_r3628881477
########## drill-ranger/drill-ranger-plugin/dependency-reduced-pom.xml: ########## @@ -0,0 +1,315 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> + <parent> + <artifactId>drill-ranger-parent</artifactId> + <groupId>org.apache.drill</groupId> + <version>1.23.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + <artifactId>drill-ranger-plugin</artifactId> + <name>Drill : Ranger Drill Authorization Plugin</name> + <description>Apache Ranger authorization plugin for Apache Drill. + Loaded by the Drillbit at runtime; performs local in-memory policy + evaluation against policies pulled from Ranger Admin. Does NOT connect + to Drill and does NOT depend on drill-jdbc.</description> + <build> + <plugins> + <plugin> + <artifactId>maven-compiler-plugin</artifactId> + <version>3.8.1</version> + <configuration> + <source>${java.version}</source> + <target>${java.version}</target> + </configuration> + </plugin> + <plugin> + <artifactId>maven-shade-plugin</artifactId> + <version>3.2.4</version> + <executions> + <execution> + <phase>package</phase> + <goals> + <goal>shade</goal> + </goals> + <configuration> + <artifactSet> + <includes> + <include>org.apache.ranger:ranger-plugins-common</include> + <include>org.apache.ranger:ranger-plugins-audit</include> + </includes> + </artifactSet> + <relocations> + <relocation> + <pattern>com.google.common</pattern> + <shadedPattern>org.apache.ranger.shaded.com.google.common</shadedPattern> + </relocation> + </relocations> + </configuration> + </execution> + </executions> + </plugin> + </plugins> + </build> + <dependencies> + <dependency> + <groupId>io.netty</groupId> + <artifactId>netty-handler</artifactId> + <version>4.1.118.Final</version> Review Comment: very old - security contingent too We have this in the main pom.xml. ``` <netty.version>4.1.135.Final</netty.version> ``` You should be able to omit the version here and with other other netty jars (below). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
