I have been hacking on commons jci as a standardised api for all our compilers. However commons jci relies on commons logging. As Drools grows and we rely on more third party resources we are going to struggle to dissallow logging from module dependencies - in this case it now effects drools-java, drools-groovy, drools-jsr and drools-examples. I have discussed a ripped version of jci among other alternatives. Looking to get feedback from other developers on this issue.

Mark
--- Begin Message --- http://issues.apache.org/bugzilla/show_bug.cgi?id=37394 Groovy no longer allows null CompilerConfiguration

I'm also just writting a simple CompilerFactory class. Once that is done I'll weigh up either ripping jci into the Drools tree sans common-logging requirement or build an event model instead.

Mark
Torsten Curdt wrote:
What about a filter? ;)

No not subscribed to commons dev - would have done if you had a mailing list just for JCI but don't wan't all the other crap that comes through.

Mark
Torsten Curdt wrote:
Oh missed this one out:
http://issues.apache.org/bugzilla/show_bug.cgi?id=37394 Groovy no longer allows null CompilerConfiguration
Mark Proctor wrote:
Torsten,

I've done a fair bit of work on jci tonight, trying to get it ship shape for Drools. Can you commit these asap so that I can do further work with a clean checkout.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37389 Optional ClassLoader http://issues.apache.org/bugzilla/show_bug.cgi?id=37390 implement removeResourceStore http://issues.apache.org/bugzilla/show_bug.cgi?id=37391 add System.gc() to ReloadingClassLoaderTestCase tea... http://issues.apache.org/bugzilla/show_bug.cgi?id=37393 AbstractCompilerTestCase hard codes .java but Groov...

I'm on http://irc.codehaus.org #drools (aka conan) if you need to chat.

I'll try to look into that tonight.

Mark, are you subscribed to commons dev?

cheers
--Torsten






--- End Message ---
--- Begin Message ---
http://issues.apache.org/bugzilla/show_bug.cgi?id=37394 Groovy no longer allows null CompilerConfiguration

I'm also just writting a simple CompilerFactory class.

Cool!

Once that is done I'll weigh up either ripping jci
into the Drools tree sans common-logging requirement or build an event model instead.

We should work something out ...unfortunately I have
been a little busy the past few weeks. So not much
progress here. The bytecode removal seems to be a
bit tricky as it's not really clear where the logging
part starts and where it stops. Probably possible
but tricky.

I really dislike the idea of a fork at this stage.
As of the event model - it just feels a bit like
re-inventing commons-logging.

Couldn't you rather mock the commons-logging API?
That way everything is fine as it is and IF someone
wants to plug in some logging he just have to replace
the mocks with the real commons-logging.

cheers
--
Torsten

Attachment: PGP.sig
Description: This is a digitally signed message part


--- End Message ---

Reply via email to