This sounds great to me too. Has anyone raised a PR yet? If not -- Abson, would you mind doing so at https://github.com/druid-io/druid?
On Tue, Jun 12, 2018 at 9:02 AM Charles Allen <charles.al...@snap.com.invalid> wrote: > This would actually be helpful as more recent log4j json formats have > better and more controllable options. This helps when druid stdout/stderr > logs get pumped directly into a rich logging system (like stackdriver or > splunk or sumologic). But there are a few changes in tests that need to be > fixed to accommodate newer versions. And if anyone is running custom log4j > plugins (pretty common) it can affect that as well. > > I'm +1 for upgrading log4j though > > On Tue, Jun 12, 2018 at 7:24 AM <abson.sae-t...@swisscom.com> wrote: > > > Hi, > > We realized on our production cluster that we're missing log files. After > > some investigation it seem that old version of log4j (< 2.8) has a > maximum > > nb of files set to 7 for the Default Rollover Strategies > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__apache-2Dlogging.6191.n7.nabble.com_Max-2Dindex-2Dlimit-2Din-2DDefaultRolloverStrategy-2Dtd75592.html&d=DwIGaQ&c=ncDTmphkJTvjIDPh0hpF_w&r=HrLGT1qWNhseJBMYABL0GFSZESht5gBoLejor3SqMSo&m=sj4O8z3MxHdxyf62OHMCGou7JGFNE0EBmlBWXwfvmZE&s=lop_6kILhYHYU-coZD4bZ-nZq0YgDbz4vJAKIkpv550&e= > . > > From version 2.8 this default was removed ( > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__logging.apache.org_log4j_2.x_manual_appenders.html-23RollingFileAppender&d=DwIGaQ&c=ncDTmphkJTvjIDPh0hpF_w&r=HrLGT1qWNhseJBMYABL0GFSZESht5gBoLejor3SqMSo&m=sj4O8z3MxHdxyf62OHMCGou7JGFNE0EBmlBWXwfvmZE&s=xcE3haXTrQzaJKrT0rXKchwdAQPjwvVXNzMbHPazGx4&e= > ). > > Would it has a lot of impact to update log4j to a more recent version ? > > Cheers > > Abson > > >
