Never mind, I see Gian has already suggested to include the fix in https://github.com/druid-io/druid/pull/5878.
On Thu, Jun 28, 2018 at 11:30 AM, Samarth Jain <samarth.j...@gmail.com> wrote: > How about https://github.com/druid-io/druid/pull/5878? It looks like a > pretty serious regression too, IMHO. > > On Tue, Jun 26, 2018 at 11:05 AM, Jihoon Son <jihoon...@apache.org> wrote: > >> Thanks guys. >> >> I'll try to finish 5729 and 5745 in this week and then start the release >> process for 0.12.2. >> >> Jihoon >> >> On Tue, Jun 26, 2018 at 10:42 AM Prashant Deva <prashant.d...@gmail.com> >> wrote: >> >> > Jihoon, >> > +1 for adding those kafka indexing bugs to 0.12.2 >> > >> > Prashant >> > >> > >> > On Mon, Jun 25, 2018 at 1:54 PM Gian Merlino <g...@apache.org> wrote: >> > >> > > I am in favor of including these in 0.12.2 as we work towards >> > robustifying >> > > Kafka indexing. >> > > >> > > On Mon, Jun 25, 2018 at 11:15 AM Jihoon Son <jihoon...@apache.org> >> > wrote: >> > > >> > > > Hi guys, >> > > > >> > > > some bugs recently have been reported for Kafka indexing service, >> and >> > > they >> > > > look worthwhile to fix in our next release as well. >> > > > Here are some issues related. >> > > > >> > > > - Broken contract of Appenderator in KafkaIndexTask ( >> > > > https://github.com/druid-io/druid/issues/5729) >> > > > - Kafka Indexing Service task pause forever until timeout if no >> events >> > in >> > > > taskduration? (https://github.com/druid-io/druid/issues/5656, PR >> > > availabe) >> > > > - ConcurrentModificationException in KafkaIndexTask ( >> > > > https://github.com/druid-io/druid/issues/5745) >> > > > - Kafka: Reordered segment allocation causes spurious failures ( >> > > > https://github.com/druid-io/druid/issues/5761, PR available) >> > > > - KafkaSupervisor NPE in checkPendingCompletionTasks when a group >> times >> > > out >> > > > (https://github.com/druid-io/druid/issues/5900) >> > > > >> > > > I'm currently working on https://github.com/druid-io/dr >> uid/issues/5729 >> > > and >> > > > https://github.com/druid-io/druid/issues/5745, and PRs will be >> ready >> > in >> > > > this week. >> > > > >> > > > What do you guys think about including fixes for these bugs in >> 0.12.2? >> > > > >> > > > Jihoon >> > > > >> > > > On Mon, Jun 25, 2018 at 10:52 AM Prashant Deva < >> > prashant.d...@gmail.com> >> > > > wrote: >> > > > >> > > > > +1 for 0.12.2. >> > > > > >> > > > > We would rather have those fixes now than wait till 0.13. >> > > > > >> > > > > Prashant >> > > > > >> > > > > >> > > > > On Wed, Jun 20, 2018 at 11:55 PM Gian Merlino <g...@apache.org> >> > wrote: >> > > > > >> > > > > > I think we're hoping that the next major (0.13) will also be our >> > > first >> > > > > > Apache release. If it ends up taking too long we might want to >> > > rethink >> > > > > that >> > > > > > but hopefully it won't (see the recently started thread about >> the >> > > next >> > > > > > step, migrating the Github repos). >> > > > > > >> > > > > > On Wed, Jun 20, 2018 at 10:42 PM Roman Leventov < >> > > leventov...@gmail.com >> > > > > >> > > > > > wrote: >> > > > > > >> > > > > > > Why won't release 13.0 instead (as non-Apache)? >> > > > > > > >> > > > > > > On Thu, 21 Jun 2018, 08:18 Gian Merlino, <g...@apache.org> >> > wrote: >> > > > > > > >> > > > > > > > +1 >> > > > > > > > >> > > > > > > > I would suggest adding these two as well. >> > > > > > > > >> > > > > > > > https://github.com/druid-io/druid/pull/5878 - Fix >> inefficient >> > > > > > available >> > > > > > > > segment cache population in SQLMetadataSegmentManager. >> > > > > > > > https://github.com/druid-io/druid/pull/5873 - >> > > > HdfsDataSegmentPusher: >> > > > > > > Close >> > > > > > > > tmpIndexFile before copying it. >> > > > > > > > >> > > > > > > > On Tue, Jun 12, 2018 at 11:34 AM Prashant Deva < >> > > > > > prashant.d...@gmail.com> >> > > > > > > > wrote: >> > > > > > > > >> > > > > > > > > +1 >> > > > > > > > > >> > > > > > > > > On Fri, Jun 8, 2018 at 3:37 PM Jihoon Son < >> > > jihoon...@apache.org> >> > > > > > > wrote: >> > > > > > > > > >> > > > > > > > > > Hi guys, >> > > > > > > > > > >> > > > > > > > > > we have a couple of bug fix PRs available and some of >> them >> > > fix >> > > > > > > > regression >> > > > > > > > > > bugs. >> > > > > > > > > > >> > > > > > > > > > Here is the list of currently available bug fix PRs >> which >> > are >> > > > not >> > > > > > > > > included >> > > > > > > > > > in 0.12.1. >> > > > > > > > > > >> > > > > > > > > > Regression bug fixes >> > > > > > > > > > - https://github.com/druid-io/druid/pull/5858 >> > > > > > > > > > - https://github.com/druid-io/druid/pull/5805 >> > > > > > > > > > - https://github.com/druid-io/druid/pull/5807 >> > > > > > > > > > >> > > > > > > > > > Non-regression bug fixes >> > > > > > > > > > - https://github.com/druid-io/druid/pull/5850 >> > > > > > > > > > - https://github.com/druid-io/druid/pull/5815 >> > > > > > > > > > - https://github.com/druid-io/druid/pull/5856 >> > > > > > > > > > >> > > > > > > > > > I think it's worth to make another release for users. >> > > > > > > > > > >> > > > > > > > > > Welcome any idea. >> > > > > > > > > > >> > > > > > > > > > Jihoon >> > > > > > > > > > >> > > > > > > > > -- >> > > > > > > > > Prashant >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > >> > > >> > >> > >
