jihoonson commented on a change in pull request #5980: Various changes about
druid-services module
URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r201151691
##########
File path: services/src/main/java/io/druid/cli/CliOverlord.java
##########
@@ -355,14 +355,13 @@ public void initialize(Server server, Injector injector)
final ObjectMapper jsonMapper =
injector.getInstance(Key.get(ObjectMapper.class, Json.class));
final AuthenticatorMapper authenticatorMapper =
injector.getInstance(AuthenticatorMapper.class);
- List<Authenticator> authenticators = null;
AuthenticationUtils.addSecuritySanityCheckFilter(root, jsonMapper);
// perform no-op authorization for these resources
AuthenticationUtils.addNoopAuthorizationFilters(root, UNSECURED_PATHS);
AuthenticationUtils.addNoopAuthorizationFilters(root,
authConfig.getUnsecuredPaths());
- authenticators = authenticatorMapper.getAuthenticatorChain();
+ List<Authenticator> authenticators =
authenticatorMapper.getAuthenticatorChain();
Review comment:
Can be final.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
