jihoonson commented on a change in pull request #5492: Native parallel batch
indexing without shuffle
URL: https://github.com/apache/incubator-druid/pull/5492#discussion_r201891599
##########
File path:
extensions-core/kafka-indexing-service/src/main/java/io/druid/indexing/kafka/KafkaIndexTaskClient.java
##########
@@ -312,10 +237,13 @@ public DateTime getStartTime(final String id)
{
log.debug("GetCheckpoints task[%s] retry[%s]", id, retry);
try {
- final FullResponseHolder response = submitRequest(id, HttpMethod.GET,
"checkpoints", null, retry);
- return jsonMapper.readValue(response.getContent(), new
TypeReference<TreeMap<Integer, TreeMap<Integer, Long>>>()
- {
- });
+ final FullResponseHolder response = submitRequestWithEmptyContent(id,
HttpMethod.GET, "checkpoints", null, retry);
+ return deserialize(
+ response.getContent(),
+ new TypeReference<TreeMap<Integer, Map<Integer, Long>>>()
Review comment:
`new TypeReference<TreeMap<Integer, Map<Integer, Long>>>()` is used only in
three places: KafkaIndexTaskClient.getCheckpoints(),
KafkaSupervisor.createKafkaTasksForGroup(), and
IncrementalPublishingKafkaIndexTaskRunner.getCheckPointsFromContext(). Maybe
it's worth to make a class or something like a static variable, but this is
related to Kafka indexing service anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
