drcrallen commented on a change in pull request #5913: Move Caching Cluster Client to java streams and allow parallel intermediate merges URL: https://github.com/apache/incubator-druid/pull/5913#discussion_r202769131
########## File path: server/src/main/java/io/druid/client/CachingClusteredClient.java ########## @@ -471,94 +552,162 @@ private CachePopulator getCachePopulator(String segmentId, Interval segmentInter return cachePopulatorMap.get(StringUtils.format("%s_%s", segmentId, segmentInterval)); } - private SortedMap<DruidServer, List<SegmentDescriptor>> groupSegmentsByServer(Set<ServerToSegment> segments) + /** + * Check the input stream to see what was cached and what was not. For the ones that were cached, merge the results + * and return the merged sequence. For the ones that were NOT cached, get the server result sequence queued up into + * the stream response + * + * @param segmentOrResult A list that is traversed in order to determine what should be sent back. All segments + * should be on the same server. + * + * @return A sequence of either the merged cached results, or the server results from any particular server + */ + private Sequence<T> runOnServer(List<ServerMaybeSegmentMaybeCache<T>> segmentOrResult) Review comment: Fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org