nishantmonu51 opened a new issue #6040: Review comment - Prohibit Usage of isNullOrEmpty and isEmpty for null handling URL: https://github.com/apache/incubator-druid/issues/6040 It seems to me that usage of com.google.guava.common.base.Strings.isNullOrEmpty(), java.lang.String.isEmpty(), etc. should be prohibited too in favor of NullHanlding.isNullOrEquivalent() and StringUtils.isNullOrEmptyNonDruidDataString() (should create such method)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org