nishantmonu51 commented on a change in pull request #5958: Part 2 of changes
for SQL Compatible Null Handling
URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r204811571
##########
File path: sql/src/main/java/io/druid/sql/calcite/rel/DruidSemiJoin.java
##########
@@ -294,7 +295,11 @@ public RelOptCost computeSelfCost(final RelOptPlanner
planner, final RelMetadata
for (int i : rightKeys) {
final Object value = row[i];
- final String stringValue = value != null ? String.valueOf(value)
: "";
+ if (value == null) {
+ // NULLS are not supposed to match NULLs in a join. So ignore
them.
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org
For additional commands, e-mail: dev-h...@druid.apache.org
