I could take a look after 0.13.0 is released. Right now things related to that are the main things I am spending my Druid-related time on.
I haven't read most of the diff yet, but I was wondering, is there a reason you make a new class instead of using SegmentIdentifier? They are slightly different (one has a ShardSpec and one just has the partition num) but I am wondering if these need to be two different classes or not. On Mon, Nov 12, 2018 at 4:51 AM Roman Leventov <leven...@apache.org> wrote: > Could somebody please provide design review of "Introduce SegmentId class" > PR : https://github.com/apache/incubator-druid/pull/6370? This is an > important improvement, and many other improvements and bugs fixes are > blocked on it. Despite "Development Blocker" tag (that was thought to give > PRs a priority), nobody reviewed this PR for almost two months, except Egor > with whom we work for the same company. >
