-1 due to wrong copyright year in NOTICE file. Checked hashes, LICENSE, NOTICE, DISCLAIMER; compiled on Ubuntu JDK 8 (skipping tests); checked that file contents match git commit; ran apache-rat.
Copyright year in NOTICE is 2018. I recommend that you obsolete https://dist.apache.org/repos/dist/dev/incubator/druid/KEYS <https://dist.apache.org/repos/dist/dev/incubator/druid/KEYS>. Keys must live in https://dist.apache.org/repos/dist/release/incubator/druid/KEYS <https://dist.apache.org/repos/dist/release/incubator/druid/KEYS>, and it is error-prone to have them in two locations. I wasted some time because I imported from the latter. I recommend that you add a README file that describes the java version required. I tried building on JDK 11 and JDK 9 before I happened on JDK 8. The audience of a source release is a developer, possibly years in the future, trying to build from source, and by then instructions in web sites may be out of date. We know this use case is not typical, but it is important. Julian > On Mar 15, 2019, at 6:25 PM, Jonathan Wei <[email protected]> wrote: > > Hi all, > > I have created a build for Apache Druid (incubating) 0.14.0, release > candidate 1. > > Thanks to everyone who has contributed to this release! You can read the > proposed release notes here: > https://github.com/apache/incubator-druid/issues/7126 > > The release candidate has been tagged in GitHub as > druid-0.14.0-incubating-rc1 (88ef108), available here: > https://github.com/apache/incubator-druid/releases/tag/druid-0.14.0-incubating-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/incubator/druid/0.14.0-incubating-rc1/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/jonwei.asc. This key and the key > of other committers can also be found in the project's KEYS file here: > > https://dist.apache.org/repos/dist/dev/incubator/druid/KEYS > > (If you are a committer, please feel free to add your own key to that file > by following the instructions in the file's header.) > > Please review the proposed artifacts and vote. Please note that Apache has > specific > requirements that must be met before +1 binding votes can be cast by PMC > members. Please refer to the policy at > http://www.apache.org/legal/release-policy.html#policy for more details. > > As part of the validation process, the release artifacts can be generated > from source by running: mvn clean install -Papache-release -Dtar > > This vote will be open for at least 72 hours but likely more, in following > the Druid community's practice of deploying the RC to larger clusters and > allowing it to soak for a period of time to flush out any remaining issues. > The vote will pass if a majority of at least three +1 PMC votes are cast. > > Once the vote has passed, the second stage vote will be called on the > Apache Incubator mailing list to get approval from the Incubator PMC. > > [ ] +1 Release this package as Apache Druid (incubating) 0.14.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Thanks!
