+1 Downloaded, checked hashes and signatures, checked LICENSE, NOTICE and DISCLAIMER, compared source distro to git hash, compiled using JDK 8 on Ubuntu linux (did not run tests), ran RAT. A few issues are noted below.
Thanks for putting the build instructions in a README in the root directory of the distro. The official build command is "mvn clean install" but I used "mvn -DskipTests clean install"; the tests failed for me, as always. I think you should change the command in README if you don't expect the tests to pass. You probably didn't intend to include several derby.log files in the release[1]. Not a blocker, but I suggest that you either remove them or at least check that there is no private information in the logs. There is also web-console/lib/sql-function-doc.ts, which appears to be generated. Not sure if that is intended to be in the source distro. Julian [1] $ find . -name derby.log |xargs ls -l -rw-r--r-- 1 jhyde jhyde 3669 Jun 7 14:23 ./extensions-contrib/materialized-view-maintenance/derby.log -rw-r--r-- 1 jhyde jhyde 1217 Jun 7 14:23 ./extensions-contrib/materialized-view-selection/derby.log -rw-r--r-- 1 jhyde jhyde 40358 Jun 7 14:15 ./extensions-core/druid-basic-security/derby.log -rw-r--r-- 1 jhyde jhyde 69194 Jun 7 14:14 ./extensions-core/kafka-indexing-service/derby.log -rw-r--r-- 1 jhyde jhyde 28776 Jun 7 14:19 ./extensions-core/kinesis-indexing-service/derby.log -rw-r--r-- 1 jhyde jhyde 18053 Jun 7 14:16 ./extensions-core/lookups-cached-global/derby.log -rw-r--r-- 1 jhyde jhyde 5950 Jun 7 14:21 ./extensions-core/lookups-cached-single/derby.log -rw-r--r-- 1 jhyde jhyde 119462 Jun 7 14:10 ./indexing-service/derby.log -rw-r--r-- 1 jhyde jhyde 84469 Jun 7 14:06 ./server/derby.log On Tue, Jun 11, 2019 at 12:48 AM Clint Wylie <cwy...@apache.org> wrote: > > +1 (non-binding) > > src package: > - verified signature/hash > - ran RAT check > - compiled and ran unit tests > - ran integration tests > - built binary distribution, ran native batch and Kafka indexing quickstart > tutorials with local deep storage with compiled artifacts, issued queries > against ingested data > > bin package: > - verified signature/hash > - ran Hadoop and Kafka indexing quickstart tutorials with hdfs deep > storage, issued queries against ingested data > > I found a couple of issues with the Kafka tutorial and opened > https://github.com/apache/incubator-druid/pull/7862. Since this is a doc > only change, I don't think it should affect the vote on this RC since the > website docs are not dependent on what is packaged in the release. > > A note to anyone else running the quickstart tutorials to try and validate > function of the packages, these docs have been updated as part of this > release, so be sure to refer to the doc source files in tag in github, > https://github.com/apache/incubator-druid/blob/0.15.0-incubating/docs/content/tutorials/index.md > instead > of the current releases docs on the website. > > > On Mon, Jun 10, 2019 at 12:45 PM Jihoon Son <jihoon...@apache.org> wrote: > > > Hi all, > > > > I have created a build for Apache Druid (incubating) 0.15.0, release > > candidate 1. > > > > Thanks to everyone who has contributed to this release! You can read the > > proposed release notes here: > > https://github.com/apache/incubator-druid/issues/7854 > > > > The release candidate has been tagged in GitHub as > > druid-0.15.0-incubating-rc1 (35f39d8), available here: > > > > https://github.com/apache/incubator-druid/releases/tag/druid-0.15.0-incubating-rc1 > > > > The artifacts to be voted on are located here: > > > > https://dist.apache.org/repos/dist/dev/incubator/druid/0.15.0-incubating-rc1/ > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/jihoonson.asc. This key and the > > key > > of other committers can also be found in the project's KEYS file here: > > > > https://dist.apache.org/repos/dist/release/incubator/druid/KEYS > > > > (If you are a committer, please feel free to add your own key to that file > > by following the instructions in the file's header.) > > > > Please review the proposed artifacts and vote. Please note that Apache has > > specific > > requirements that must be met before +1 binding votes can be cast by PMC > > members. Please refer to the policy at > > http://www.apache.org/legal/release-policy.html#policy for more details. > > > > As part of the validation process, the release artifacts can be generated > > from source by running: mvn clean install -Papache-release -Dtar > > > > This vote will be open for at least 72 hours but likely more, in following > > the Druid community's practice of deploying the RC to larger clusters and > > allowing it to soak for a period of time to flush out any remaining issues. > > The vote will pass if a majority of at least three +1 PMC votes are cast. > > > > Once the vote has passed, the second stage vote will be called on the > > Apache Incubator mailing list to get approval from the Incubator PMC. > > > > [ ] +1 Release this package as Apache Druid (incubating) 0.15.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > Thanks! > > Jihoon > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org For additional commands, e-mail: dev-h...@druid.apache.org
