Hi Julian, I would be happy to review your Spark-Druid connector PRs. Ingesting data into Druid using Spark SQL and Dataframe API is something we are very keen to onboard. Could you point me to them or alternatively add me as a reviewer?
- Samarth On Tue, Apr 13, 2021 at 11:51 PM Julian Jaffe <julianfja...@gmail.com> wrote: > Hey Gian and other Druids, > > Is there anything I can do to encourage reviews of this code? Would a dev > guide or design doc be helpful to reviewers? Can I bribe someone with > chocolate :)? > > Thanks, > Julian > > > On Mar 2, 2021, at 9:53 AM, Gian Merlino <g...@apache.org> wrote: > > > > Thank you! > > > >> On Thu, Feb 25, 2021 at 12:03 AM Julian Jaffe <julianfja...@gmail.com> > >> wrote: > >> > >> Hey Gian, > >> > >> I’d be overjoyed to be proven wrong! For what it’s worth, my pessimism > was > >> not driven by a lack of faith in the Druid community or the Druid > >> committers but by the fact that these connectors may be an awkward fit > in > >> the Druid code base without more buy-in from the community writ large. > >> > >> The information you’re asking for is spread across a few places. I’ll > >> consolidate it into the PR, emphasizing the UX and the tests. I should > have > >> it up within a day or so. > >> > >> Thanks, > >> Julian > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > >> For additional commands, e-mail: dev-h...@druid.apache.org > >> > >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > For additional commands, e-mail: dev-h...@druid.apache.org > >
