My vote is 0 on this release. I verified the usual things, and compared the src and bin packages against 0.22.0 to make sure there were no unexpected changes. That all looks OK to me. But there is an issue with weird errors at the end of logfiles for processes that exit normally. It's especially noticeable for indexing tasks. It looks like some issue with the shutter-downer stuff that was introduced in https://github.com/apache/druid/pull/1387. The error looks like the following. If this is fixable I think it'd be good to fix it in 0.22.1-rc2. But if we can't get that done today, I think it's OK to go ahead with releasing 0.22.1-rc1 with this listed as a known issue, because the security issue is serious and shouldn't wait another day.
2021-12-10T23:13:38,740 ERROR [main] org.apache.druid.java.util.common.lifecycle.Lifecycle$AnnotationBasedHandler - Exception when stopping method[public void org.apache.druid.initialization.Log4jShutterDownerModule$Log4jShutterDowner.stop()] on object[org.apache.druid.initialization.Log4jShutterDownerModule$Log4jShutterDowner@30a5a58d ] java.lang.reflect.InvocationTargetException: null at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?] at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?] at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?] at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?] at org.apache.druid.java.util.common.lifecycle.Lifecycle$AnnotationBasedHandler.stop(Lifecycle.java:465) [druid-core-0.22.1.jar:0.22.1] at org.apache.druid.java.util.common.lifecycle.Lifecycle.stop(Lifecycle.java:368) [druid-core-0.22.1.jar:0.22.1] at org.apache.druid.cli.CliPeon.run(CliPeon.java:323) [druid-services-0.22.1.jar:0.22.1] at org.apache.druid.cli.Main.main(Main.java:113) [druid-services-0.22.1.jar:0.22.1] Caused by: org.apache.druid.java.util.common.ISE: Expected state [STARTED] found [INITIALIZED] at org.apache.druid.common.config.Log4jShutdown.stop(Log4jShutdown.java:105) ~[druid-core-0.22.1.jar:0.22.1] at org.apache.druid.initialization.Log4jShutterDownerModule$Log4jShutterDowner.stop(Log4jShutterDownerModule.java:116) ~[druid-server-0.22.1.jar:0.22.1] ... 8 more Finished peon task On Fri, Dec 10, 2021 at 12:25 PM Jihoon Son <jihoon...@apache.org> wrote: > Hi all, > > I have created a build for Apache Druid 0.22.1, release > candidate 1. > > Thanks to everyone who has helped contribute to the release! You can read > the proposed release notes here: > https://github.com/apache/druid/issues/12054 > > The release candidate has been tagged in GitHub as > druid-0.22.1-rc1 (c052fa52b2266e25c5c31b9156c530aa29aeb147), > available here: > https://github.com/apache/druid/releases/tag/druid-0.22.1-rc1 > > The artifacts to be voted on are located here: > https://dist.apache.org/repos/dist/dev/druid/0.22.1-rc1/ > > A staged Maven repository is available for review at: > https://repository.apache.org/content/repositories/orgapachedruid-1027/ > > A Docker image containing the binary of the release candidate can be > retrieved via: > docker pull apache/druid:0.22.1-rc1 > > artifact checksums > src: > > 9a6304d2c434e0a8226ef8621c1d6653cf80eca10e2be24936b98ec4f7cc19f80193599aea6cd3992a6998e600134e6e71d001630b7e51ca0ab98310850cc064 > bin: > > eceacdb0ffca7da462eddc31aaed735c02f639c6f7bafc826fd050095c00a84bffc5694f0887d43436d704e3686e437d44e1a226b4f0d7701f9c450c63f1e1c8 > docker: 929d217c5c86d59b69db3f0202387a4b0103c8a35b7011ce8e00e95582ade380 > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/jihoonson.asc > > This key and the key of other committers can also be found in the project's > KEYS file here: > https://dist.apache.org/repos/dist/release/druid/KEYS > > (If you are a committer, please feel free to add your own key to that file > by following the instructions in the file's header.) > > > Verify checksums: > diff <(shasum -a512 apache-druid-0.22.1-src.tar.gz | \ > cut -d ' ' -f1) \ > <(cat apache-druid-0.22.1-src.tar.gz.sha512 ; echo) > > diff <(shasum -a512 apache-druid-0.22.1-bin.tar.gz | \ > cut -d ' ' -f1) \ > <(cat apache-druid-0.22.1-bin.tar.gz.sha512 ; echo) > > Verify signatures: > gpg --verify apache-druid-0.22.1-src.tar.gz.asc \ > apache-druid-0.22.1-src.tar.gz > > gpg --verify apache-druid-0.22.1-bin.tar.gz.asc \ > apache-druid-0.22.1-bin.tar.gz > > Please review the proposed artifacts and vote. Note that Apache has > specific requirements that must be met before +1 binding votes can be cast > by PMC members. Please refer to the policy at > http://www.apache.org/legal/release-policy.html#policy for more details. > > As part of the validation process, the release artifacts can be generated > from source by running: > mvn clean install -Papache-release,dist -Dgpg.skip > > The RAT license check can be run from source by: > mvn apache-rat:check -Prat > > Because we want to make this release as soon as possible, this vote will be > open for at least "6" hours unlike other regular release votes. > > The vote will pass if a > majority of at least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Druid 0.22.1 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Thanks! >
