+1 I don't see there's a need for committers to click the 'Approve' button to run CI for every PR.
On Tue, Mar 28, 2023 at 2:27 PM Austin Bennett <[email protected]> wrote: > Beam did the same. > > +1 on allowing contributors to keep things moving [where appropriate, > which this can be if CI is setup well], allowing committers to focus on > more/other activities > > On Mon, Mar 27, 2023, 11:24 PM Gian Merlino <[email protected]> wrote: > > > Recently, ASF GitHub repos had their defaults for GitHub Actions changed > to > > "always require approval for external contributors". In Slack, Karan > > pointed out that Airflow has recently submitted a ticket to have that > > changed back: https://issues.apache.org/jira/browse/INFRA-24200. IMO, we > > should do the same. I don't think we have a problem with fake PRs, but we > > can always improve our responsiveness to contributors from outside the > > project! Every little bit helps, including running CI automatically. > > > > If others have opinions on this, let me know. I'd like to raise our own > > ticket to change our default. > > > > Gian > > >
