Understood, I would still prefer if we filed explicit PRs for all changes regardless of whether they are repetitive or not. Just like we avoid committing directly to the main branch, we should not commit directly to release branches. It also ensures those changes are captured in the mailing list as required.
On Wed, Jul 12, 2023 at 5:42 PM Abhishek Agarwal <abhis...@apache.org> wrote: > We have been doing it for the last 3-4 releases that it has almost become > like a guaranteed release activity. Hopefully, by the next release, we > won't have to do this again. > > On Wed, Jul 12, 2023 at 7:04 PM Xavier Léauté <xav...@confluent.io.invalid > > > wrote: > > > ok, we should still go through a proper PR review and not make unilateral > > changes to the release branches. > > If it's too cumbersome to do so, then we might want to consider removing > > the helm charts from the main branch and wait for IP clearance resolution > > before adding them back. > > > > On Wed, Jul 12, 2023 at 7:40 AM Abhishek Agarwal <abhis...@apache.org> > > wrote: > > > > > Xavier, > > > I removed these from release branch since we still don't have a > consensus > > > on IP clearance of helm charts > > > https://lists.apache.org/thread/dbypwsj7ykpkqyzm7gvopmprpw76r5oc > > > > > > On Wed, Jul 12, 2023 at 2:23 AM Xavier Léauté > > <xav...@confluent.io.invalid > > > > > > > wrote: > > > > > > > Abhishek, > > > > > > > > Is there a reason for this commit to be in the release branch? I > don't > > > see > > > > a PR or review for it > > > > > > > > > > > > > > https://github.com/apache/druid/commit/911372d5d6523f425a46fbbafae728bdca441f0f > > > > > > > > > > > > Thanks, > > > > Xavier > > > > > > > > On Sat, Jul 8, 2023 at 6:00 AM Abhishek Agarwal <abhis...@apache.org > > > > > > wrote: > > > > > > > > > I have cut the branch - > https://github.com/apache/druid/tree/27.0.0. > > > > > > > > > > On Sat, Jul 8, 2023 at 12:25 AM Abhishek Agarwal < > > abhis...@apache.org> > > > > > wrote: > > > > > > > > > > > I can do it. > > > > > > > > > > > > On Fri, Jul 7, 2023 at 10:25 PM Amatya Avadhanula < > > ama...@apache.org > > > > > > > > > > wrote: > > > > > > > > > > > >> Hello > > > > > >> > > > > > >> As I'm traveling, I may not be able to cut the branch tomorrow. > > > > > >> Could I please request another committer to do it in my place? > > > > > >> > > > > > >> Apologies for the late notice. > > > > > >> > > > > > >> Regards > > > > > >> Amatya > > > > > >> > > > > > >> > > > --------------------------------------------------------------------- > > > > > >> To unsubscribe, e-mail: dev-unsubscr...@druid.apache.org > > > > > >> For additional commands, e-mail: dev-h...@druid.apache.org > > > > > >> > > > > > >> > > > > > > > > > > > > > > >
