razinbouzar commented on PR #10: URL: https://github.com/apache/druid-operator/pull/10#issuecomment-4057586720
thank @lee-rvt. this lgtm just a couple of observations: 1. Verified that zz_generated.deepcopy.go is already excluded from [rat runs](https://github.com/apache/druid-operator/blob/be47102a08db487e7e052a74d85911d94cf3c2d9/Makefile#L143). 2. Should [apis/druid/v1alpha1/groupversion_info.go](https://github.com/apache/druid-operator/blob/master/apis/druid/v1alpha1/groupversion_info.go), [apis/druid/v1alpha1/doc.go](https://github.com/apache/druid-operator/blob/master/apis/druid/v1alpha1/doc.go), and [controllers/druid/suite_test.go](https://github.com/apache/druid-operator/blob/master/controllers/druid/suite_test.go) also be updated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
