razinbouzar commented on PR #2: URL: https://github.com/apache/druid-operator/pull/2#issuecomment-4205963346
@AdheipSingh @abhishekrb19 protobuf is still only an indirect dependency, with no direct API usage. I also checked module hygiene on the PR branch with go mod tidy -diff, and it produced no diff. For further validation, I locally tested the actual Apache PR head in an isolated checkout. After provisioning the expected envtest assets for Kubernetes 1.26.0, the full local test suite passed with go test ./..., including the envtest-backed controller tests: - github.com/datainfrahq/druid-operator/controllers/druid - github.com/datainfrahq/druid-operator/controllers/ingestion - github.com/datainfrahq/druid-operator/pkg/druidapi - github.com/datainfrahq/druid-operator/pkg/util I did not find any protobuf-related regressions or follow-up changes needed, so this looks safe to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
