codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=h1) Report > Merging [#1380](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/1ca021ca71841ab1a32e017f5836daaf2c2d59a0?src=pr&el=desc) will **decrease** coverage by `2.58%`. > The diff coverage is `3.07%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1380 +/- ## ========================================== - Coverage 31.56% 28.98% -2.59% ========================================== Files 682 685 +3 Lines 33035 35972 +2937 Branches 6592 6985 +393 ========================================== - Hits 10428 10426 -2 - Misses 20754 23686 +2932 - Partials 1853 1860 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...java/com/alibaba/dubbo/demo/ThriftDemoService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2RlbW8vVGhyaWZ0RGVtb1NlcnZpY2UuamF2YQ==) | `0% <ø> (ø)` | | | [...om/alibaba/dubbo/demo/provider/ThriftProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnRQcm92aWRlci5qYXZh) | `0% <0%> (ø)` | | | [...om/alibaba/dubbo/demo/provider/ThriftDemoImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnREZW1vSW1wbC5qYXZh) | `0% <0%> (ø)` | | | [...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=) | `3.92% <0%> (-0.12%)` | :arrow_down: | | [...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=) | `20.81% <0%> (-0.26%)` | :arrow_down: | | [...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh) | `39.53% <50%> (+0.09%)` | :arrow_up: | | [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `51.89% <0%> (-3.8%)` | :arrow_down: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `57.5% <0%> (-3.75%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.97% <0%> (-1.45%)` | :arrow_down: | | ... and [5 more](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=footer). Last update [1ca021c...78d8241](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
