bearDream commented on a change in pull request #1506: Update ServiceConfig.java URL: https://github.com/apache/incubator-dubbo/pull/1506#discussion_r178050826
########## File path: dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ServiceConfig.java ########## @@ -491,7 +491,7 @@ private void doExportUrlsFor1Protocol(ProtocolConfig protocolConfig, List<URL> r } if (registryURLs != null && !registryURLs.isEmpty()) { for (URL registryURL : registryURLs) { - url = url.addParameterIfAbsent("dynamic", registryURL.getParameter("dynamic")); + url = url.addParameterIfAbsent(Constants.DYNAMIC_KEY, registryURL.getParameter("dynamic")); Review comment: emmm... you are right, I will update it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services