codecov-io commented on issue #1572: remove the method with the same function but the different name in Ne… URL: https://github.com/apache/incubator-dubbo/pull/1572#issuecomment-379647522 # [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=h1) Report > Merging [#1572](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/497803c836e46ede3a91e79865eef0fe567e4ea9?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1572 +/- ## ========================================== + Coverage 32.17% 32.18% +0.01% ========================================== Files 682 682 Lines 32972 32970 -2 Branches 6597 6596 -1 ========================================== + Hits 10608 10612 +4 + Misses 20468 20463 -5 + Partials 1896 1895 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [.../java/com/alibaba/dubbo/common/utils/NetUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL3V0aWxzL05ldFV0aWxzLmphdmE=) | `15.9% <ø> (+0.23%)` | :arrow_up: | | [...ba/dubbo/common/logger/support/FailsafeLogger.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2xvZ2dlci9zdXBwb3J0L0ZhaWxzYWZlTG9nZ2VyLmphdmE=) | `13.41% <100%> (ø)` | :arrow_up: | | [...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==) | `67.85% <0%> (-3.58%)` | :arrow_down: | | [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `73.14% <0%> (-2.78%)` | :arrow_down: | | [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `55.22% <0%> (-1.5%)` | :arrow_down: | | [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `59.42% <0%> (+1.44%)` | :arrow_up: | | [.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=) | `56.56% <0%> (+2.02%)` | :arrow_up: | | [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1572/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `66.25% <0%> (+8.75%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=footer). Last update [497803c...a220110](https://codecov.io/gh/apache/incubator-dubbo/pull/1572?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
