codecov-io commented on issue #1646: Method extraction & Unnecessary code 
remove & Typo fix
URL: https://github.com/apache/incubator-dubbo/pull/1646#issuecomment-383268305
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=h1) 
Report
   > Merging 
[#1646](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/d43faf447bf7e9b99ce189fe60f176e094920d39?src=pr&el=desc)
 will **decrease** coverage by `0.01%`.
   > The diff coverage is `71.87%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/graphs/tree.svg?width=650&src=pr&token=VnEIkiFQT0&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1646      +/-   ##
   ============================================
   - Coverage     34.54%   34.52%   -0.02%     
   - Complexity     3686     3688       +2     
   ============================================
     Files           621      621              
     Lines         30875    30880       +5     
     Branches       5448     5448              
   ============================================
   - Hits          10666    10662       -4     
   - Misses        18373    18382       +9     
     Partials       1836     1836
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=tree) | 
Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...libaba/dubbo/common/extension/ExtensionLoader.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9FeHRlbnNpb25Mb2FkZXIuamF2YQ==)
 | `71.63% <71.87%> (+0.7%)` | `114 <44> (+4)` | :arrow_up: |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | `3% <0%> (ø)` | |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `67.27% <0%> (-3.64%)` | `8% <0%> (-1%)` | |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | `13% <0%> (ø)` | |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
   | 
[...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh)
 | `77.2% <0%> (-1.48%)` | `29% <0%> (ø)` | |
   | 
[...libaba/dubbo/rpc/protocol/dubbo/DubboProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1646/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9EdWJib1Byb3RvY29sLmphdmE=)
 | `60.08% <0%> (-0.9%)` | `32% <0%> (-1%)` | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=footer).
 Last update 
[d43faf4...8e9450b](https://codecov.io/gh/apache/incubator-dubbo/pull/1646?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to