> - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not > required) Not this will make the connivance binary LICENSE file different to > the source LICENSE file
FastJSON should not be part of the binary release, should be caused by a bug of filters, i will remove it. > - The binary jars in libs are missing LICENSE and NOTICE files in META-INF We prefer to use the same LICENSE and NOTICE files in libs to fill the missing part of each binary jar, Best regards, Jun > On 11 May 2018, at 12:05 PM, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > I saw that a release candidate has been put up here [1] and I had a quick > look at it. It looks good to me with a couple of minor issues: > - The binary LICENSE fails to mention FastJSON (but as this is ALv2 it’s not > required) Not this will make the connivance binary LICENSE file different to > the source LICENSE file > - The binary jars in libs are missing LICENSE and NOTICE files in META-INF > > You may want to fix these before calling a vote but I think this sees could > be fixed in the next release if you prefer that. Other mentors/PMC member may > have a different opinion to me. > > Thanks, > Justin > > 1. https://dist.apache.org/repos/dist/dev/incubator/dubbo/2.6.2/
