Thanks to review this PR, I will update site_config/doc.js tomorrow.

Thanks.
Xiaobo

> 在 2018年12月17日,下午11:26,Huxing Zhang <hux...@apache.org> 写道:
> 
> Hi,
> 
> The pull request looks good to me, I have merge the pr[1].
> 
> To make sure your docs appear in the sidebar of
> http://dubbo.apache.org/zh-cn/docs/user/quick-start.html, would you
> please also update site_config/doc.js?
> 
> If you check site_config/doc.js, you can see there is lots of examples.
> 
> [1] https://github.com/apache/incubator-dubbo-website/pull/197
> 
> On Mon, Dec 10, 2018 at 2:21 PM 田 小波 <tianxiaobo....@outlook.com> wrote:
>> 
>> Hi community,
>> 
>> I just submitted my source analysis article to dubbo-website, the PR number 
>> is #197 [1], please help check.
>> 
>> [1] https://github.com/apache/incubator-dubbo-website/pull/197
>> 
>> Thanks!
>> Xiaobo
>> 
>> 在 2018年12月10日,上午11:55,雷舜宇 
>> <shunyuma...@gmail.com<mailto:shunyuma...@gmail.com>> 写道:
>> 
>> I said that I am currently doing the service-completed comments completion
>> work. If there is a problem, I will exchange this on the mailing list.
>> 
>> 田 小波 <tianxiaobo....@outlook.com<mailto:tianxiaobo....@outlook.com>> 
>> 于2018年12月10日周一 上午10:03写道:
>> 
>> OK, I will submit a PR tomorrow.
>> 
>> 在 2018年12月9日,下午4:50,Ian Luo <ian....@gmail.com<mailto:ian....@gmail.com>> 写道:
>> 
>> I will take a look, and talk to you on pull request.
>> 
>> -Ian.
>> 
>> On Fri, Dec 7, 2018 at 6:11 PM 田 小波 
>> <tianxiaobo....@outlook.com<mailto:tianxiaobo....@outlook.com>> wrote:
>> 
>> Ian:
>> I will make some simple changes to these articles and submit them to
>> dubbo-website. Limited to personal abilities, if there are any mistakes
>> in
>> the article, please help to modify and improve.
>> 
>> 我会对这些文章做一些简单的修改,然后将这些文章提交给
>> dubbo-website。限于个人能力,如果文章中有错误不妥之处,还请大家帮忙修改和完善。
>> 
>> Thanks!
>> Xiaobo
>> 
>> Pls. go ahead to submit your articles:
>> 
>> Then we can involve other peoples in the community to join the effort.
>> 
>> What do you think?
>> 
>> Thanks,
>> -Ian.
>> 
>> 
>> 
>> 
> 
> 
> -- 
> Best Regards!
> Huxing

Reply via email to