Hi,
I don’t think it’s a problem about number of reviewers , As time goes by,
we will slowly ignore it,We pay more attention to the new issue.



Huxing Zhang <hux...@apache.org> 于2019年3月7日周四 下午5:04写道:

> Hi,
>
> When I am looking at the pull request, I found a pull request[1] got
> approved by 2 of our reviewers(committers), but still not getting
> merged.
>
> I am thinking why it is like this. Should we set up community rules
> for thing like this?
> For example, if a pull request has got at least N approval from
> committers, it can be merged, where N can be discussed. The more
> approval it need, the longer process it will take.
>
> For large size pull requests, the reviewer can request another one to
> help on it.
>
> I would suggest to keep it small, N=1.  Even the reviewer fails to
> identify the issues, it can be fixed by sending another pull request.
>
> How do you think?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3536
>
> --
> Best Regards!
> Huxing
>

Reply via email to