Hi，the script is used for checking the binary dependency licenses, so I put it in the binary release
On Wed, Mar 20, 2019 at 11:14 AM Ian Luo <ian....@gmail.com> wrote: > I vote with: > [v] +1 approve > > Minor issues: > > In the binary distributions, there's one script file named > 'bin-distribution-check.sh' which should not be included. > > Is the issue minor? > [v] Yes [] No [] Unsure > Could it possibly be fixed in the next release? > [v] Yes [] No [] Unsure > > Details: > > [v] Are release files in correct location? > [v] Do release files have the word incubating in their name? > [v] Are the digital signature and hashes correct? > [v] Does DISCLAIMER file exist? > [v] Do LICENSE and NOTICE files exists? > [v] Is the LICENSE and NOTICE text correct? > [v] Is the NOTICE year correct? > [v] Un-included software dependencies are not mentioned in LICENSE or > NOTICE? > [v] License information is not mentioned in NOTICE? > > Is there any 3rd party code contained inside the release? If so: > > [v] Does the software have a compatible license? > [v] Are all software licenses mentioned in LICENSE? > [v] Is the full text of the licenses (or pointers to it) in LICENSE? > > Is any of this code Apache licensed? Do they have NOTICE files? If so: > > [v] Have relevant parts of those NOTICE files been added to this NOTICE > file? > [v] Do all source files have ASF headers? > [v] Do the contents of the release match with what's tagged in version > control? > [x] Are there any unexpected binary files in the release? > [v] Can you compile from source? Are the instruction clear? > > Regards, > -Ian. > > > On Tue, Mar 19, 2019 at 11:21 PM Minxuan Zhuang <z82507...@gmail.com> > wrote: > > > the subject has been corrected, please continue voting. > > On Tue, Mar 19, 2019 at 10:51 PM Huxing Zhang <hux...@apache.org> wrote: > > > > > Hi, > > > > > > Supposing the title is vote thread, it should be started with "[VOTE]: > > > Release Apache Dubbo Admin(Incubating) 0.2.0 [RC2]" > > > > > > On Tue, Mar 19, 2019 at 6:52 PM Minxuan Zhuang <z82507...@gmail.com> > > > wrote: > > > > > > > > Hello Dubbo Community, > > > > > > > > This is a call for the vote to release Apache Dubbo > Admin(Incubating) > > > > version 0.2.0 > > > > > > > > The release candidates(RC2): > > > > 0.2.0: > > > > * > > > > > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/dubbo-admin/0.2.0/ > > > > < > > > > > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/dubbo-admin/0.2.0/ > > > >* > > > > > > > > Git tag for this release: > > > > 0.2.0: * > > > https://github.com/apache/incubator-dubbo-admin/releases/tag/0.2.0 > > > > <https://github.com/apache/incubator-dubbo-admin/releases/tag/0.2.0 > >* > > > > > > > > Hash for the release tag: > > > > 0.2.0: 4ba387f78d2ecdd11b0c034b7c0bbe86a176fc6a > > > > > > > > Release Notes: > > > > 0.2.0: > > > > *https://github.com/apache/incubator-dubbo-ops/releases/tag/0. > > > > <https://github.com/apache/incubator-dubbo-ops/releases/tag/0.1>2.0* > > > > > > > > The artifacts have been signed with Key: DA2108479B0C1E71, which can > be > > > > found in > > > > the keys file: > > > > > > > > *https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > > > <https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS>* > > > > > > > > The vote will be open for at least 72 hours or until the necessary > > number > > > > of votes are reached. > > > > > > > > Please vote accordingly: > > > > > > > > [ ] +1 approve > > > > [ ] +0 no opinion > > > > [ ] -1 disapprove with the reason > > > > > > > > Thanks, > > > > The Apache Dubbo (Incubating) Team > > > > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > >
