I also vote -1, a lot of *.flattened-pom.xml* files should be removed from source code, they are useless, thus I will vote again.
Kind regards, Mercy Ma On Thu, Mar 28, 2019 at 10:27 AM Ian Luo <ian....@gmail.com> wrote: > -1, > > Minor issues, please fix in the next release: > > - There are lots of .flattened-pom.xml in source release, which does > > not exist in Github tag. For example: > > Only in > > > apache-dubbo-spring-boot-project-incubating-2.7.1-source-release/dubbo-spring-boot-actuator: > > .flattened-pom.xml > > > I think we should fix this, and the signature issue too. > > Thanks, > -Ian. > > > On Wed, Mar 27, 2019 at 11:23 PM Huxing Zhang <hux...@apache.org> wrote: > > > Hi, > > > > I vote with: > > +1 release the software > > > > Are release files in correct location? Yes > > Do release files have the word incubating in their name? Yes > > Are the digital signature and hashes correct? Yes > > Does DISCLAIMER file exist? Yes > > Do LICENSE and NOTICE files exists? Yes > > Is the LICENSE and NOTICE text correct? Yes > > Is the NOTICE year correct? Yes > > Un-included software dependencies are not mentioned in LICENSE or > > NOTICE? Yes > > License information is not mentioned in NOTICE? Yes > > Is there any 3rd party code contained inside the release? No > > Do all source files have ASF headers? Yes > > Do the contents of the release match with what's tagged in version > > control? Yes (There is some minor issue, see comments below) > > Are there any unexpected binary files in the release? No. > > Can you compile from source? Are the instruction clear? Yes. > > UT passed on MacOS and Java 11 > > > > Minor issues, please fix in the next release: > > - There are lots of .flattened-pom.xml in source release, which does > > not exist in Github tag. For example: > > Only in > > > apache-dubbo-spring-boot-project-incubating-2.7.1-source-release/dubbo-spring-boot-actuator: > > .flattened-pom.xml > > - The sha512 checksum should be marked as '*', please use -b to > > generate that token. > > > > > 13d266f1f1c0352cdcb0a034d5147e3e5122adf37ef92a0d38af8b644ea5a302db3dd331ad7621967ab740966def061091e6b8acddcd0d500c4b74964228c3c1 > > apache-dubbo-spring-boot-project-incubating-2.7.1-bin-release.zip > > > > On Wed, Mar 27, 2019 at 10:22 PM Mercy Ma <mercybl...@apache.org> wrote: > > > > > > Hello Dubbo Community, > > > > > > This is a call for the vote to release Apache Dubbo Spring Boot Project > > > (Incubating) version 2.7.1 (RC1) > > > > > > The release candidates > > > 2.7.1: > > > > > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/spring-boot-project/2.7.1 > > > > > > The staging repo: > > > https://repository.apache.org/content/repositories/orgapachedubbo-1017 > > > > > > Git tag for the release: > > > 2.7.1: * > > > https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/2.7.1 > > > < > > > https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/2.7.1 > > >* > > > > > > Hash for the release tag: > > > 2.7.0: d7a1d14a9aae063b0acf7cc0bd74e197cbe9111f > > > > > > Release Notes: > > > 2.7.1: > > > > > > https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/2.7.1 > > > > > > The artifacts have been signed with Key: > > > 87F025027A831ED2B86E7F08A7F508EFDA68B4F5, which can be found in the > keys > > > file: > > > https://dist.apache.org/repos/dist/dev/incubator/dubbo/KEYS > > > > > > The vote will be open for at least 72 hours or until the necessary > number > > > of votes are reached. > > > > > > Please vote accordingly: > > > > > > [ ] +1 approve > > > [ ] +0 no opinion > > > [ ] -1 disapprove with the reason > > > > > > Thanks, > > > The Apache Dubbo (Incubating) Team > > > > > > > > -- > > Best Regards！ > > Huxing > > > -- *Mercy Ma* GMail:mercybl...@gmail.com Yahoo: mercy.bl...@yahoo.com Wetchat: mercyblitz-1985 Twitter : @mercyblitz <http://twitter.com/mercyblitz> Blog : https://mercyblitz.github.io/
