Hi, On Tue, May 28, 2019 at 1:40 PM YunKun Huang <[email protected]> wrote: > > I think split source file and generated file into two branch will be much > better: > > 1.source file branch will be the only truth of website, all commit and merge > operation will impact website content. new contributor doesn't need care > about other js files and html files. > 2.source file branch's size will reduce, people (or Jenkins CI) can clone it > quickly > 3.Each time people run docsite build, it will generate many html and js[1] > etc. Keep them at one branch may cause more push conflict and PR conflict. > 4.unnecessary file is sync to static file server, refer to [2]. There is no > security issue but just not necessary
+1 to split into two branches. > > And for current deployment process, we only commit website to github and > apache server will sync it. so in order to build website in jenkins, we need > at least one token or ssh key to push files. My understanding will be: push code to source code branch -> trigger jenkins build to generate static file -> push to static file branch -> automatically sync to Apache server. I am not sure it could be achieved or not, maybe ask infra to confirm? > does it possible to push file directly to apache server? Not quit sure, but I think it is better to push back to Github because the generated files need to be kept, so that someone can test it locally. > or any one know the ticket link for this website setup work? It is here: https://issues.apache.org/jira/browse/INFRA-16207 > > [1]: > https://github.com/apache/dubbo-website/commit/1a5777396389c5f48dd796cc9ff03f9351bc2e14 > [2]: http://dubbo.apache.org/webpack.config.js > > On 2019/05/27 13:10:02, Huxing Zhang <[email protected]> wrote: > > Hi, > > > > On Mon, May 27, 2019 at 11:01 AM YunKun Huang <[email protected]> wrote: > > > > > > hey, > > > > > > I'm working on continuous deployment for Dubbo, and want to create a > > > jenkins job for building & deploying dubbo-website for each commit. > > > > > > I think currently we are using some manual process, my understanding is > > > > > > 1. commit doc change to asf-site branch > > > 2. someone will run `docsite build` to generate website and push to > > > asf-site branch > > > 3. upload new website to somewhere? (a static web server maybe?) > > > > Step 3, statics files will be synced to Apache server automatically. > > > > > > > > My question is > > > 1. for step 1 and step 2, should we keep source for website and generated > > > files for website in two different branch > > > > Keeping all files in one branch is just a simple solution. Do you see > > any advantage to keep in two different branches? I think it can be > > discussed. > > > > > 2. where do we host static files? in apache server? > > > > Yes. In Apache Server. > > > > > > > > > > > > -- > > Best Regards! > > Huxing > > -- Best Regards! Huxing
