+1 to release. I checked: * Source package has a good name, ‘incubating' removed. * DISCLAIMER LICENSE and NOTICE exist * No binary files exist in source package * Can compile and all UT pass in my local machine with 'mvn clean test’ except for a few ones in the following file - org.apache.dubbo.metadata.store.etcd.EtcdMetadataReportTest, I think it’s not a functional issue, the reason is my machine does not match this UT's it’s docker requirement. * All files have License header and meet checkstyle requirements: mvn clean compile -Drat.skip=false -Dcheckstyle.skip=false * Release notes are good
Question: - Are we still releasing the binary package for this version? I saw the binary package ‘apache-dubbo-2.7.2-bin.zip’ in https://dist.apache.org/repos/dist/dev/dubbo/2.7.2/, if we are not releasing, should we remove it now? Suggestion: - I think we should refine the release notes in here https://github.com/apache/dubbo/releases/tag/dubbo-2.7.2, only highlight the most important and cared features. Guide people who want to see details to https://github.com/apache/dubbo/blob/dubbo-2.7.2/CHANGES.md for more info. Jun > On May 31, 2019, at 7:16 PM, victory <[email protected]> wrote: > > Hello Dubbo Community, > > This is a call for vote to release Apache Dubbo version 2.7.2. > > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/2.7.2/ > > Git tag for the release: > https://github.com/apache/dubbo/tree/dubbo-2.7.2 > > Hash for the release tag: > 0ab26b170b40f146707cdab0b4436e32df4f5e9a > > Release Notes: > https://github.com/apache/dubbo/blob/dubbo-2.7.2/CHANGES.md > > The artifacts have been signed with Key : A3A1CA7A5D4A3981, which can be > found in the keys file: > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > The vote will be open for at least 72 hours or until necessary number of > votes are reached. > > Please vote accordingly: > > [ ] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason > > Thanks, > The Apache Dubbo Team
