Hi, On Mon, Jun 10, 2019 at 2:29 PM Daniela Morais <[email protected]> wrote: > > There are 2 projects: dubbo-rpc-jms and dubbo-rpc-activemq. > dubbo-rpc-jms has only 1 file on META-INF/dubbo > (org.apache.dubbo.rpc.Protocol) and JmsImplementor interface is an > extension point. Doesn't have any implementation defined in the > configuration file. > > Question: > ActivemqJmsImplementor is the only implementation of JmsImplementor. I'm > not sure if I should move ActivemqJmsImplementor to the same project as > JmsImplementor and create the file > org.apache.dubbo.rpc.jms.implementor.ActivemqJmsImplementor on > META-INF/dubbo. Is it ok?
+1 to your proposal to merge dubbo-rpc-jms-activemq to dubbo-rpc-jms. I think dubbo-rpc-rest has some similar logic, it uses resteasy as default implementation in the same module. Since it is unlikely to have other implmentation than ActiveMQ. It is ok to merge it into one. In the future if there is need to add more implementation, let's refactor it then. > > Exception on dubbo-rpc-jms > org.apache.dubbo.rpc.RpcException: Fail to create JMS Connector to jms:// > 127.0.0.1:5344/org.apache.dubbo.rpc.protocol.jms.JmsService?version=1.0.0, > cause: No such extension > org.apache.dubbo.rpc.protocol.jms.implementor.JmsImplementor by name > activemq > > On Mon, Jun 10, 2019 at 1:52 AM Huxing Zhang <[email protected]> wrote: > > > Hi, > > > > Sorry for the late reply, we had dragon-boat festival vacation last week. > > > > On Sat, Jun 8, 2019 at 10:32 AM Daniela Morais <[email protected]> > > wrote: > > > > > > Hi, > > > > > > Today I did: > > > * The task of merging dubbo-rpc-jms (#3765) overlapped with collecting > > > metrics > > > > > > Questions: > > > 1) Is there any doc that can help me with dubbo-rpc-jms? I fix the > > > conflicts (such as replace RpcResult with AppResponse) but I'm trying to > > > fix the unit tests: > > > > > > java.lang.IllegalStateException: Failed to create adaptive instance: > > > java.lang.IllegalStateException: Can't create adaptive extension > > interface > > > org.apache.dubbo.rpc.protocol.jms.implementor.JmsImplementor, cause: No > > > adaptive method exist on extension > > > org.apache.dubbo.rpc.protocol.jms.implementor.JmsImplementor, refuse to > > > create the adaptive class! > > > at > > > > > org.apache.dubbo.rpc.protocol.jms.JmsProtocolTest.testTimeOut(JmsProtocolTest.java:58). > > > > You may need @Adaptive annotation on the > > > > org.apache.dubbo.rpc.protocol.jms.implementor.JmsImplementor#getQueueConnectionFactory > > method. > > Check http://dubbo.apache.org/en-us/blog/introduction-to-dubbo-spi.html > > for more details. > > > > > > > > 2) I need to add a CpuUsageGaugeSet on Result's attachments (attachments > > > is a Result.java attribute and is a Map<String, String>). What is the > > best > > > way to achieve this? I tried adding as a JSON: > > > CpuUsageGaugeSet cpuUsage = gson.fromJson(json, CpuUsageGaugeSet.class) > > > throws: > > > > > > "Unable to invoke no-args constructor for interface > > > com.alibaba.metrics.Metric. Registering an InstanceCreator with Gson for > > > this type may fix this problem." > > > > You can attach the cpu.user if it is the only value you are interested. > > > > > > > > Thanks, > > > > > > -- > > > Daniela Morais > > > Computer Science student at the University Of Campinas > > > danielammorais.com <https://www.danielammorais.com> > > > > > > > > -- > > Best Regards！ > > Huxing > > > > > -- > Daniela Morais > Computer Science student at the University Of Campinas > danielammorais.com <https://www.danielammorais.com> -- Best Regards！ Huxing
