+1 approve I have checked: * Can compile from source * Run with dubbo-sample, all checks pass
There is one question for CHANGES file format. Usually changes information are spilt into `New Features`, `Enhancement`, `Bugfixes`, should we keep to use this format? On Sat, Jul 13, 2019 at 10:10 AM Jun Liu <liu...@apache.org> wrote: > No source code change but only removed some empty directories and updated > the change log compared to RC2. > > I checked the following myself: > • LICENSE and NOTICE exists and contents are good > • All files and no binary files exist > • All files has standard ASF License header > • Can compile from source > • All unit tests can pass > • contents math with corresponding tag > > Jun > > > On Jul 13, 2019, at 10:05 AM, Jun Liu <liu...@apache.org> wrote: > > > > Hi, All > > > > This is a call for vote to release Apache Dubbo version 2.7.3 RC3. > > > > The release candidates (it contains only source release package) : > > https://dist.apache.org/repos/dist/dev/dubbo/2.7.3/ < > https://dist.apache.org/repos/dist/dev/dubbo/2.7.3/> > > > > Git tag for the release: > > https://github.com/apache/dubbo/tree/dubbo-2.7.3/ < > https://github.com/apache/dubbo/tree/dubbo-2.7.3/> > > > > Hash for the release tag: > > c3e122e00e9607060dd10531108e563f16ac4f7f > > > > Change list: > > https://github.com/apache/dubbo/blob/dubbo-2.7.3/CHANGES.md < > https://github.com/apache/dubbo/blob/dubbo-2.7.3/CHANGES.md> > > > > The artifacts have been signed with Key : 28681CB1, which can be > > found in the keys file: > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS < > https://dist.apache.org/repos/dist/dev/dubbo/KEYS> > > > > The vote will be open for at least 72 hours or until necessary number of > > votes are reached. > > > > Please vote accordingly: > > > > [ ] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > > > Thanks, > > The Apache Dubbo Team > >
