+1 (binding) I checked: - signatures and hashes are good - LICENSE and NOTICE exists and contents are good - All files and no binary files exist - All files has standard ASF License header - Can compile from source - All unit tests can pass
Ian Luo <ian....@gmail.com> 于2019年8月5日周一 上午11:38写道： > It's tracked with issue#569 [1] > > -Ian. > > > 1. https://github.com/apache/dubbo-spring-boot-project/issues/569 > > On Sun, Aug 4, 2019 at 12:03 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > +1 (binding) > > > > I checked: > > - signatures and hashes are good > > - LICENSE is fine > > - NOTICE still mentions incubating there no need to do that > > - All source files have ASF headers > > - No unexpected binary files > > -Can compile from source > > > > The DISCLAIMER is no longer required as this is not an incubating project > > anymore. > > > > Thanks, > > Justin > -- Best Regard! cvitory
