+1 binding.
I checked:
* signatures and hashes are good. Seems this time you signed with a new key.
* LICENSE and NOTICE exit and contents are good
* All files no binaries
* `mvn clean test` can pass: Mac + Oracle JDK 1.8
* tags match with source
* staged maven artifacts are ok.
* Issues pointed in RC1 being fixed:
- Files under ‘org.apache.dubbo.config.spring.util’ with License issue has
been fixed by signing SGA
- Included MIT license inside LICENSE file[1]
- Unreachable links or legacy internal links removed[2]
- Add license header to licenseCheck.sh
- Change notes updated
- spring-context-support related comments removed
The following two fixes[3][4] are newly added comparing to RC1.
1.
https://github.com/apache/dubbo/blob/1d7e8fac4523d7482d5f2d8f25dd024807e3d3d5/LICENSE#L229
2.
https://github.com/apache/dubbo/commit/805e2daebd7f05229281f074ed85dc9dbf090c14
3. https://github.com/apache/dubbo/pull/5135
4. https://github.com/apache/dubbo/pull/5075
Jun
> On Oct 12, 2019, at 7:26 PM, victory <vict...@apache.org> wrote:
>
> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.4.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/2.7.4/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1045
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.4
>
> Hash for the release tag:
> 1d7e8fac4523d7482d5f2d8f25dd024807e3d3d5
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.4
>
> The artifacts have been signed with Key : 35D071D458D03BB4, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
