+1 binding I have checked the following options. [√] All uts passed. [√] CHANGE.md . [√] License headers . [√] Download links are fine.
On Mon, Jul 19, 2021 at 6:21 PM stocks alex <[email protected]> wrote: > continue to release rc1 and merge it as v0.4.0. > > xun zhang <[email protected]> 于2021年7月18日周日 下午8:39写道: > > > merge this PR in rc1 or resend RC2 version ? > > > > stocks alex <[email protected]> 于2021年7月18日周日 上午8:04写道: > > > > > +1 binding. > > > > > > I have checked the following options. > > > > > > [v] Are release files in correct location? > > > [v] Do LICENSE and NOTICE files exists? > > > [v] Is the LICENSE and NOTICE text correct? > > > [v] Is the NOTICE year correct? > > > [x] Un-included software dependencies are not mentioned in LICENSE or > > > NOTICE? > > > [x] License information is not mentioned in NOTICE? > > > [v] Do the contents of the release match with what's tagged in version > > > control? > > > [x] Are there any unexpected binary files in the release? > > > > > > As other problems, I have submit a pr > > > https://github.com/apache/dubbo-go-pixiu/pull/216 to fix them. pls > > checked > > > it. > > > > > > joezou <[email protected]> 于2021年7月16日周五 下午2:06写道: > > > > > > > +1 binding > > > > > > > > Checked > > > > [√] All uts passed. > > > > [√] CHANGE.md . > > > > [√] License headers . > > > > [√] Download links are fine. > > > > > > > > suggest: > > > > Put the latest release note on the top of CHANGES.md. > > > > > > > > xun zhang <[email protected]> 于2021年7月14日周三 下午10:48写道: > > > > > > > > > Hello Dubbo/Dubbogo Community, > > > > > > > > > > This is a call for vote to release Apache dubbo-go-pixiu version > > > > > 0.3.0-rc1 > > > > > > > > > > The release candidates: > > > > > > > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-pixiu/v0.3.0-rc1/ > > > > > > > > > > Git tag for the release: > > > > > https://github.com/apache/dubbo-go-pixiu/releases/tag/v0.3.0-rc1 > > > > > > > > > > Hash for the release tag: > 43c2b05557b392de76aed354a614d1f4379e4f94 > > > > > > > > > > Release Notes: > > > > > https://github.com/apache/dubbo-go-pixiu/blob/0.3.0/CHANGE.md > > > > > > > > > > The artifacts have been signed with Key : > > > > > 9C44C5967D97E1220AAC9433A9C2A64BFF4095D9, which can be > > > > > found in the keys file: > > > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > > > > > > > > > The vote will be open for at least 72 hours or until the > necessary > > > > number > > > > > of > > > > > votes are reached. > > > > > > > > > > Please vote accordingly: > > > > > [ ] +1 approve > > > > > [ ] +0 no opinion > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > Thanks, > > > > > The Apache Dubbo-go Team > > > > > > > > > > > > > > > -- Regards, Wongoo
