+1 binding Checked [√] License headers . [√] Download Links are fine. [√] The LICENSE text is correct. [√] Release notes.
wongoo <won...@apache.org> 于2022年6月8日周三 15:52写道： > +1 (binding) > > I checked: > + Download links are fine. > + LICENSE and NOTICE files exist. > + Sources can compile. > + All uts passed. > > On Wed, Jun 8, 2022 at 7:54 AM zhaoyunxing <zhaoyunx...@apache.org> wrote: > > > 感谢指正，KEYS文件我已经更新，麻烦再查看下 > > > > wongoo <won...@apache.org> 于2022年6月7日周二 13:02写道： > > > > > > The release candidates: > > > > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.7 > > > > > > > > > The link is wrong, it should be > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.8/. > > > > > > > > > gpg --import KEYS > > > > gpg: key C9E40526CE1E29C1: public key "zhaoyunxing (dubbo) < > > > > zhaoyunx...@apache.org>" imported > > > > gpg --verify dubbo-go-v1.5.8-src.tar.gz.asc > dubbo-go-v1.5.8-src.tar.gz > > > > gpg: Signature made Fri Jun 3 23:15:43 2022 CST > > > > gpg: using RSA key > > > C08344DD055342502123D41E919AACF2C1BB1517 > > > > gpg: issuer "zhaoyunx...@apache.org" > > > > gpg: Can't check signature: No public key > > > > > > > > > The sign key used is not the same as in the KEYS file. > > > > > > > > > On Sun, Jun 5, 2022 at 2:45 PM ztelur <zte...@apache.org> wrote: > > > > > > > +1 (binding) . > > > > > > > > I checked the following items. > > > > > > > > [v] LICENSE and NOTICE exist and contents are good > > > > [v] Tag and hash can match > > > > [v] Signature can be found in the keys file > > > > [v] Release notes look fine > > > > [v] Unit tests passed on my Mac > > > > [v] there are no any unexpected binary files in the release. > > > > > > > > On Sun, Jun 5, 2022 at 11:07 AM stocks alex <alexsto...@apache.org> > > > wrote: > > > > > > > > > +1 (binding) . > > > > > > > > > > I checked the following items. > > > > > > > > > > [v] Are release files in the correct location? > > > > > [v] Do LICENSE and NOTICE files exist? > > > > > [v] Is the LICENSE and NOTICE text correct? > > > > > [v] Is the NOTICE year correct? > > > > > [x] Un-included software dependencies are not mentioned in LICENSE > or > > > > > NOTICE? > > > > > [x] License information is not mentioned in NOTICE? > > > > > [v] Do the contents of the release match with what's tagged in > > > > > versioncontrol? > > > > > [x] Are there any unexpected binary files in the release? > > > > > > > > > > zhaoyunxing <zhaoyunx...@apache.org> 于2022年6月4日周六 00:14写道： > > > > > > > > > > > Hello Dubbo/Dubbogo Community > > > > > > > > > > > > > > > > > > This is a call for vote to release Apache Dubbo-go version 1.5.8 > > > > > > > > > > > > > > > > > > The release candidates: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.7 > > > > > > > > > > > > > > > > > > Git tag for the release: > > > > > > > > > > > > https://github.com/apache/dubbo-go/tree/v1.5.8 > > > > > > > > > > > > > > > > > > > > > > > > Hash for the release tag: > > > > > > > > > > > > 19ca5d1d2de82876d1dbc3acc1219e46674757cc > > > > > > > > > > > > > > > > > > Release Notes: > > > > > > > > > > > > https://github.com/apache/dubbo-go/releases/tag/v1.5.8 > > > > > > < > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/dubbo-go/releases/tag/untagged-4d5e0c01ab00654b7ed1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The artifacts have been signed with Key : > > > > > > 072985E0578F2B4E037672B2C9E40526CE1E29C1, which can be > > > > > > found in the keys file: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > > > > > > > > > > > > > > > > > > > > > > > The vote will be open for at least 72 hours or until necessary > > number > > > > of > > > > > > votes are reached. > > > > > > > > > > > > > > > > > > Please vote accordingly: > > > > > > > > > > > > > > > > > > [ ] +1 approve > > > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > The Apache Dubbo/Dubbogo Team > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Regards, > > > Wongoo > > > > > > > > -- > Regards, > Wongoo >
