Agree On Wed, Dec 14, 2022 at 2:02 PM Cheung Andy <[email protected]> wrote:
> Hi All, > > It has been a long time that the Apache Dubbo Error Code Inspector works > in tolorence mode due to historical reasons. Hence, the > error-code-inspecting GitHub workflow always passes the test regardless the > logging method invocations contains error code or not. > > Since almost all logging method invocations have the corresponding error > codes, and there're some absences of error codes in the 3.2 branch, in > order to raise the awareness of the error code mechanism, I would like to > start a discussion that about the timing of making the Error Code Inspector > 'really' works. > > I do suggest that the Error Code Inspector should 'really' work after the > 3.1 branch passes the test. Fell free to state your opinions. > > Thanks, > Andy Cheung >
