+1 binding, I have checked: * LICENSE and NOTICE exist and contents are good * Hash and signature are good * Unit tests can pass on my Mac with go 1.20 * All source files no binary
Jun Liu <ken.lj...@gmail.com> 于2023年12月11日周一 17:41写道: > > +1 binding, > > I have checked: > * LICENSE and NOTICE exist and contents are good > * Hash and signature are good > * Unit tests can pass on my Mac with go 1.20 > * All source files no binary > > Minor issue, release note does not look clear enough for users. It would be > better if we have brief conclusion of the issues and prs. > > > Regards, > Jun Liu > > > > > On Dec 2, 2023, at 2:29 PM, Xuewei Niu <justxue...@apache.org> wrote: > > > > Hello Dubbo/Dubbogo community > > > > This is a vote for the release of Apache Dubbo-go v3.1.1-rc1. > > > > Release candidates: > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v3.1.1-rc1 > > > > Git tags published: > > https://github.com/apache/dubbo-go/tree/v3.1.1-rc1 > > > > Publish tag hash: > > d204c4ef491dd22c58c4fd2e0a30e0f9d4e57715 > > > > The artifact has been signed with a key: > > 8FDE893A8DE5184C7F76ECB9B9185984BF7D6735, it can be found in the KEYS file > > https://dist.apache.org/repos/dist/dev/dubbo/KEYS > > > > Polls will remain open for at least 72 hours or until the necessary number > > of votes is reached. > > > > Please vote accordingly: > > [] +1 Yes > > [] +0 no opinion > > [] -1 Do not approve, cause > > > > Thank you, Apache Dubbo/Dubbogo team >