[ https://issues.apache.org/jira/browse/EAGLE-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059650#comment-15059650 ]
ASF GitHub Bot commented on EAGLE-75: ------------------------------------- Github user haoch commented on the pull request: https://github.com/apache/incubator-eagle/pull/28#issuecomment-165023954 LGTM, please merge according to https://cwiki.apache.org/confluence/display/EAG/Contributing+to+Eagle > Leverage dropwizard metrics for generating Eagle Topology and DataSource > Metrics > -------------------------------------------------------------------------------- > > Key: EAGLE-75 > URL: https://issues.apache.org/jira/browse/EAGLE-75 > Project: Eagle > Issue Type: Sub-task > Affects Versions: 0.3.0 > Reporter: Libin, Sun > Assignee: Libin, Sun > Fix For: 0.3.0 > > > As a monitoring system, eagle need to report & record both the datasource > data distribution metric & topology running status metrics to let user have > better understanding of the system running status. > Previously we added a simple metric framework to support user cases like > [EAGLE-2](https://issues.apache.org/jira/browse/EAGLE-2) , > [EAGLE-24](https://issues.apache.org/jira/browse/EAGLE-24) > Considering we will have a lot metric user cases to onboard later, we need a > better metric framework to make it easier to support these cases, and after > some investigation, we found [Dropwizard > metrics](https://github.com/dropwizard/metrics) is a good one that can match > our needs, So we want to integrate Dropwizard metrics with eagle -- This message was sent by Atlassian JIRA (v6.3.4#6332)