Created EAGLE-104 <https://issues.apache.org/jira/browse/EAGLE-104> to track the issue and attached the patch. will run the tests and submit pull request. Are we suppose to use ReviewBoard or some other tool for code reviews ?
thanks Prasad On Mon, Dec 28, 2015 at 1:37 AM, Prasad Mujumdar <pras...@apache.org> wrote: > > Looks like the problem is that the UGI parsing method is not handling > the simple authentication scenario where user name is not a kerberos > principal. I can log a ticket and submit a patch if nobody else is looking > into this. > > thanks > Prasad > > > On Sun, Dec 27, 2015 at 9:27 PM, Michael Wu <mchl....@gmail.com> wrote: > >> Hi guys, >> >> While I was trying to kick off a build at >> https://builds.apache.org/job/incubator-eagle-pr-reviewer, an exception >> was >> thrown out from a unit test method with the message pasted at the bottom. >> Could anyone who is responsible for this unit test to take a look and fix >> it, please? Otherwise it may block pull requests from getting passed for >> CI >> verification. >> Error message from Unit test: >> ********************************** >> <testcase time="0.615" classname=" >> org.apache.eagle.security.TestHDFSSecuritylogParser" name="test"> >> <error message="String index out of range: -1" type=" >> java.lang.StringIndexOutOfBoundsException"> >> java.lang.StringIndexOutOfBoundsException: String index out of range: -1 >> at >> java.lang.String.substring(String.java:1911) at >> >> org.apache.eagle.security.util.LogParseUtil.parseUserFromUGI(LogParseUtil.java:39) >> at >> >> org.apache.eagle.security.securitylog.parse.HDFSSecurityLogParser.parseAttr(HDFSSecurityLogParser.java:78) >> at >> >> org.apache.eagle.security.securitylog.parse.HDFSSecurityLogParser.parse(HDFSSecurityLogParser.java:52) >> at >> >> org.apache.eagle.security.TestHDFSSecuritylogParser.test(TestHDFSSecuritylogParser.java:36) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at >> >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >> at >> >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:606) at >> >> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) >> at >> >> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) >> at >> >> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) >> at >> >> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) >> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) at >> >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) >> at >> >> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) >> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) at >> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) at >> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) at >> org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) at >> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) at >> org.junit.runners.ParentRunner.run(ParentRunner.java:300) at >> >> org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:59) >> at >> >> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:120) >> at >> >> org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:103) >> at org.apache.maven.surefire.Surefire.run(Surefire.java:169) at >> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at >> >> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) >> at >> >> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:606) at >> >> org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:350) >> at >> >> org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1021) >> </error> >> <system-err> >> log4j:WARN No appenders could be found for logger >> (org.apache.eagle.common.config.EagleConfigFactory). log4j:WARN Please >> initialize the log4j system properly. log4j:WARN See >> http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. >> </system-err> >> </testcase> >> ********************************** >> >> To get more detailed info about the error, please refer to >> >> https://builds.apache.org/job/incubator-eagle-pr-reviewer/ws/eagle-security/eagle-security-hdfs-securitylog/target/surefire-reports/ >> >> Thanks. >> Michael >> > >