this script has to be run within the git working directory which is connected to apache github repo, right? and if so, why not we make this script as part of our source code for example put it into root directory of incubator-eagle?
Thanks Edward From: Michael Wu <mchl....@gmail.com<mailto:mchl....@gmail.com>> Reply-To: "dev@eagle.incubator.apache.org<mailto:dev@eagle.incubator.apache.org>" <dev@eagle.incubator.apache.org<mailto:dev@eagle.incubator.apache.org>> Date: Wednesday, December 30, 2015 at 23:12 To: "dev@eagle.incubator.apache.org<mailto:dev@eagle.incubator.apache.org>" <dev@eagle.incubator.apache.org<mailto:dev@eagle.incubator.apache.org>> Subject: Re: [GitHub] incubator-eagle pull request: EAGLE-78 add configuration requireme... Edward, send the script to you. Here is a log fragment of my tests, please ignore the git repo url in it, the real url of eagle has been placed in the attached script, you don't need to modify anything but download the script to any git working directory and open a console and run ./merge_pull_request.py -n 39. If there is anything that doesn't follow our criteria, it will notify in output: -------------------- START PROCESSING -------------------- INF: query pr information from github... INF: will use "am_eagle_remote" as a remote name to operate INF: looking up comments from github... INF: verified: this pr is reviewed by ['anyway1021'] and finally approved by ['anyway1021'], it's good to merge INF: querying email address for reviewers' account from github... INF: downloading 17.patch from github... IPT: please input the description of the merge, which will be regarded as a part of the final commit message ( to start new lines, to finish inputting): recover INF: committed to local repository on branch operating_branch_1451350746196985, the commit history now looks like: new -> * commit 643dc13d5560eae734ea1e9ac166d68adf363113 (HEAD, operating_branch_1451350746196985) | Author: ziwu ziyang...@ebay.com<mailto:ziyang...@ebay.com> | Date: Tue Dec 29 08:59:39 2015 +0800 | | EAGLE-31 recover toString() of Address.java | recover | | https://issues.apache.org/jira/browse/EAGLE-31 | | Author: @anyway1021<https://github.com/anyway1021> mchl....@gmail.com<mailto:mchl....@gmail.com> | Reviewer(s): @anyway1021<https://github.com/anyway1021> mchl....@gmail.com<mailto:mchl....@gmail.com> | | Closes #17<https://github.com/apache/incubator-eagle/pull/17>. | old -> * commit 2a935badad668b97de7c8e8a9150786c88fabb8d (am_eagle_remote/master) | Author: ziwu ziyang...@ebay.com<mailto:ziyang...@ebay.com> | Date: Mon Dec 28 22:58:14 2015 +0800 | | EAGLE-31 add street1 info to toString() of Address.java | ddaabb | | https://issues.apache.org/jira/browse/EAGLE-31 | | Author: @anyway1021<https://github.com/anyway1021> mchl....@gmail.com<mailto:mchl....@gmail.com> | Reviewer(s): @anyway1021<https://github.com/anyway1021> mchl....@gmail.com<mailto:mchl....@gmail.com> | | Closes #16<https://github.com/apache/incubator-eagle/pull/16>. * commit ...... IPT: shall we push commit <643dc13d5560eae734ea1e9ac166d68adf363113> to remote ? ():y INF: pushing to remote repository... INF: pull request <17> has been applied and pushed to remote of repository https://github.com/anyway-checker/pr-merge-test.git INF: if you're going to continue with any forked repository, please update it accordingly INF: Bye. -------------------- ENDED PROCESSING -------------------- If you find any issue of using this script, please log a comment on https://github.com/apache/incubator-eagle/pull/42 Thanks, Michael On Thu, Dec 31, 2015 at 2:57 PM, Zhang, Edward (GDI Hadoop) <yonzh...@ebay.com<mailto:yonzh...@ebay.com>> wrote: I am going to merge pull request 39, which is EAGLE-47. I did not follow your merge_pull_request.py, where do I get this python script and what is output of this script. Thanks Edward On 12/30/15, 22:48, "Michael Wu" <mchl....@gmail.com<mailto:mchl....@gmail.com>> wrote: >Edward, > >I think there may be 2 ways to reopen it: >1. you can ask the author to reopen it. >2. you can create a new one on page >https://github.com/apache/incubator-eagle/compare/master...qinzhaokun:EAGL >E-78?expand=1 >. > >BTW, were you using the script I sent to you to merge and close the PR? >With it, you only need to execute it as "merge_pull_request.py -n 47". >Tips: the number "47" is the number of the PR. The script will check the >pr >title and all other necessary info to compose the final commit message. > >And, the title of PR 47 doesn't follow our criteria: EAGLE-${jira_number} >${pr_title_content}, please ask the author to revise it or you change it >when you recreate the PR. > >Thanks. >Michael > >On Thu, Dec 31, 2015 at 2:35 PM, Zhang, Edward (GDI Hadoop) < >yonzh...@ebay.com<mailto:yonzh...@ebay.com>> wrote: > >> I made a mistake to close this pull request because I mistaken pull >> request id for jira id. >> >> Please advise how to reopen this pull request #47 >> >> Thanks >> Edward >> >> On 12/30/15, 22:12, "asfgit" >> <g...@git.apache.org<mailto:g...@git.apache.org>> wrote: >> >> >Github user asfgit closed the pull request at: >> > >> > https://github.com/apache/incubator-eagle/pull/47 >> > >> > >> >--- >> >If your project is set up for it, you can reply to this email and have >> >your >> >reply appear on GitHub as well. If your project does not have this >>feature >> >enabled and wishes so, or if the feature is enabled but not working, >> >please >> >contact infrastructure at >> >infrastruct...@apache.org<mailto:infrastruct...@apache.org> or file a JIRA >>ticket >> >with INFRA. >> >--- >> >>
