[
https://issues.apache.org/jira/browse/EAGLE-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120851#comment-15120851
]
ASF GitHub Bot commented on EAGLE-95:
-------------------------------------
Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/71#issuecomment-175999816
@murkrishn @senthilec566 I suggest a different solution.
1. define a new interface in PolicyEvaluator called isMarkedDown()
2. It is PolicyEvaluator implementation's responsibility to determine if
the policy is marked down or not. In our case, SiddhiPolicyEvaluator and
MLPolicyEvaluator should implement this above interface
3. It is PolicyEvaluator implementation's responsibility to determine if
the policy should be marked down based on parsing for Siddhi case. For
SiddhiPolicyEvaluator, we can catch exception from createSiddhiRuntime method,
then markdown this policy by setting one field(markedDown) to be true. That can
be in SiddhiPolicyEvaluator constructor method and onPolicyUpdate method
4. It is PolicyProcessExecutor's responsibility to report markdown status
back to eagle service. So probably we can check PolicyEvaluator's isMarkedDown
after policy creation or update, and then write back to eagle service.
Please suggest if that will do well.
> DAM HDFS topology fails to start, if there is invalid policy.
> -------------------------------------------------------------
>
> Key: EAGLE-95
> URL: https://issues.apache.org/jira/browse/EAGLE-95
> Project: Eagle
> Issue Type: Bug
> Reporter: hemanth dendukuri
> Assignee: Senthilkumar
> Priority: Critical
>
> Step 1: Create a invalid policy (from hdfsAuditLogEventStream[(cmd == 'open')
> and (str:contains(src,'/tmp/p')==true)] select * insert into outputStream;)
> Step 2 : Deploy Dam HDFS topology.
> Actual : The HDFS topology could not start because of the invalid policy.
> 2015-12-16 23:51:17 b.s.d.executor [INFO] Shutting down executor
> AlertEntityDeduplicationExecutor_9:[2 2] 2015-12-16 23:51:17 b.s.util [INFO]
> Async loop interrupted!
> Expected: Topology should start ignoring the invalid policy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
