Github user yonzhang commented on the pull request:
https://github.com/apache/incubator-eagle/pull/77#issuecomment-176191482
Thanks for redoing pull request. I don't understand why we need bind
notificationType with AlertDefinitionAPIEntity. Doesn't
AlertDefinitionAPIEntity has a field notificationDef where notifications are
defined. Also, one alert definition should possibly have multiple notification
types associated.Do I miss anything? (I did not mention notificationDef to you
before, sorry about that)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
