Github user RalphSu commented on a diff in the pull request:
https://github.com/apache/incubator-eagle/pull/71#discussion_r51576194
--- Diff:
eagle-core/eagle-policy/eagle-policy-base/src/main/java/org/apache/eagle/policy/dao/PolicyDefinitionDAO.java
---
@@ -21,6 +21,7 @@
import java.util.Map;
import org.apache.eagle.alert.entity.AbstractPolicyDefinitionEntity;
+import org.apache.eagle.alert.entity.AlertDefinitionAPIEntity;
--- End diff --
Why need to have AlertDefinitionAPIEntity in PolicyDefinitionDAO? Ideally
PolicyDefinitionDAO suppose not knowing any the specific subtype of
AbstractPolicyDefinitionEntity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
