[ https://issues.apache.org/jira/browse/EAGLE-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149907#comment-15149907 ]
ASF GitHub Bot commented on EAGLE-81: ------------------------------------- GitHub user yonzhang opened a pull request: https://github.com/apache/incubator-eagle/pull/89 EAGLE-81 Notification plugin 1. plugin configured in eagle service 2. plugin base interfaces 3. plugin-example in eagle-examples/eagle-topology-example 4. email is default plugin for backward compatibility Need to fix in the future: 1. email has to be really asynchronized. Today it is blocked on onAlert in plugin 2. test an external jar containing notification plugin 3. alert persist should be after entitydedupe or emaildedupe. Do we really support alert eaglestore to be a plugin? 4. email utilities need to be cleaned up once after we determine the right topology P.S. the first version if notification plugin framework is done by Senthil, I made many fundamental changes, and current version is subject to more changes also You can merge this pull request into a Git repository by running: $ git pull https://github.com/yonzhang/incubator-eagle notification-plugin Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-eagle/pull/89.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #89 ---- commit 9a202265214bc5df17fd92c9e5496b1eccfccd8e Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-10T21:01:33Z first version of notification plugin, to be changed a lot commit 0a277e8c7f1f89cedb8c276c7521d56b76858d61 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-11T06:21:17Z plugin loader commit 5927e74ec506c86df8cef0eadc29669e9517b894 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-11T19:37:05Z hook with alert executor commit 66b75183c1063d0bf82f033334f563e2ae0a2d15 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-11T22:33:03Z refactor more commit a96dc8ce542ecad6bfcc996d24088d609ae77005 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-12T00:40:20Z refactor package structure commit ce5e124e58e9ce1cc16f194c197079e54f49b1f5 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-13T05:11:10Z fix unit test for email plugin commit b4a8db3fc4d5aea08ac3da582221eca32255a1e6 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-13T06:47:18Z full unit test for all default plugins commit a32a0294f058b55155edc92dd3f9278c814bc983 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-16T04:34:24Z end-2-end testing commit 30d373be08f6e00a73fd6c3c44eba2f3371c7e40 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-17T00:53:51Z create end-2-end test case commit 98f77db369211818b0e4150cfd514b8dc3194bb0 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-17T05:04:01Z plugin config from eagle service commit 6993b914497654f3a8219a5241914bc50dcd6e1b Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-17T05:18:14Z clean up some classes commit efd487c0cd9888a464b123d3fa36ce779503ce29 Author: yonzhang <yonzh...@ebay.com> Date: 2016-02-17T05:25:57Z Merge remote-tracking branch 'upstream/master' into notification-plugin ---- > Notification Plugin Framework > ----------------------------- > > Key: EAGLE-81 > URL: https://issues.apache.org/jira/browse/EAGLE-81 > Project: Eagle > Issue Type: New Feature > Affects Versions: 0.3.0 > Reporter: Senthilkumar > Assignee: Senthilkumar > Original Estimate: 336h > Remaining Estimate: 336h > > Today notification is only allowed for email .. We need more notification > methods to send alert to external system . -- This message was sent by Atlassian JIRA (v6.3.4#6332)