[ 
https://issues.apache.org/jira/browse/EAGLE-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422465#comment-15422465
 ] 

ASF GitHub Bot commented on EAGLE-462:
--------------------------------------

Github user RalphSu commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/352#discussion_r74900271
  
    --- Diff: 
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
 ---
    @@ -35,6 +35,7 @@
         private StreamDefinition schema;
         private String createdBy;
         private long createdTime;
    +    private boolean isDuplicate = false;
    --- End diff --
    
    Looks this is only for test verification. Could we avoid add non-required 
method in stream event, instead use check the statistic info in deduplicator 
for test verify?


> Alert Dudup - same metric generate alert should be deduped
> ----------------------------------------------------------
>
>                 Key: EAGLE-462
>                 URL: https://issues.apache.org/jira/browse/EAGLE-462
>             Project: Eagle
>          Issue Type: Improvement
>            Reporter: Zeng, Bryant
>            Assignee: Zeng, Bryant
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to