Github user haoch commented on the issue:

    https://github.com/apache/incubator-eagle/pull/335
  
    `metadata.xml` is part of code, `application.conf` should just for 
standalone running mode. We should never mix them, the `value` in 
`metadata.xml` just stands for `defaultValue` and should be treated as 
configuration file. Currently we still have to manually do it. And for some 
application, i may have tens of configuration items like this app. 
    
    Better solution is make the `configuration` in `metadata.xml` be part of 
code as designed before like:
    
    ~~~
    AppConfiguration{
         @Property(name="eagle.app.configName",displayName="ConfigName", 
defaultValue="defaultValue")
         public String configName;
    }
    ~~~
    
    It should be good for:
    
    1. Provide metadata inline in typesafe way and avoid ugly get configuration 
by Config.getXXX method hidden in logic code.
    2. Automatically map configuration instance from typesafe Config through 
annotation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to